Repository navigation
Support consented automatic reviews for unconnected public contributors - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub’s collaborator-permission API returns
nonefor outside public contributors (confirmed against the real platform automation identity), even though public repository contents are readable. That prevented explicitly owner-assigned unattended reviews for unconnected public contributors.Treat this as read access only for automatic PR events when GitHub independently reports the repository as public and trusted policy configures an assigned administrator. Existing exact sender ID/type, whitelist/blacklist, installation identity, explicit owner-consent generation, live administrator permission, credential leases and separate merge authorization remain mandatory. Private repositories and manual requests retain the existing permission checks; no credentials are returned to a contributor.
Validation: Node 24 full check (196 tests), including public non-collaborator admission only after explicit consent, private denial and manual-bot denial. The already verified clean review/native APPROVE/autonomous merge and serious-bug REQUEST_CHANGES provide separate live release evidence. A real unconnected-contributor automatic review is the next live gate after deployment.
GitHub visibility contract: https://docs.github.com/en/repositories/creating-and-managing-repositories/about-repositories#about-repository-visibility